search

PrintNode / PrintNode-PHP

PHP API Library For PrintNode Remote Printing Service
https://www.printnode.com
MIT License
83 stars 64 forks source link

Apply limit and offset to GET requests #20

Open stephangroen opened 7 years ago

stephangroen commented 7 years ago

There is a method for applying the limit and offset to requests. This method was never called. Therefor there was never a limit or offset sent to the API and the API always responded based on the defaults.

Example: Getting the printer list always responded with max 100 printers.

This PR calls the applyOffsetLimit method when doing GET requests, so limit and offset get applied correctly.

Also made a small fix to declare $endPointUrls the right way, since how it was done is not supported.

Tested getting a printer list and applying small limits, combined with an offset which created the right response.

stephangroen commented 6 years ago

@PrintNodeJames @PrintNodeLtd Any change on merging this?

stephangroen commented 6 years ago

@PrintNodeJames @PrintNodeLtd Any change on merging this?

stephangroen commented 6 years ago

@PrintNodeJames @PrintNodeLtd Any change on merging this?

stephangroen commented 3 years ago

@PrintNodeJames @PrintNodeLtd Any change on merging this?