Library no longer works with PHP7.4

PrintNode / PrintNode-PHP

PHP API Library For PrintNode Remote Printing Service

https://www.printnode.com

MIT License

83 stars 64 forks source link

Library no longer works with PHP7.4 #48

Closed timramakers closed 1 year ago

timramakers commented 1 year ago

The 'mixed' pseudotype is used in the last commit, seemingly added for PHP8 compatibility. This is not available in PHP7.4 and throws a fatal error.

This caused all of our client's applications to break. Therefore, we are moving away from this PHP library since it's not reliable.

To improve in the future:

please create releases so we users have control over which version we are using. Using dev-master in composer.json is not acceptable for any kind of production environment;
please test in all supported versions of PHP before putting out a new release.

DjThossi commented 1 year ago

I agree the last commit was not a good idea in master branch. The Person pushed up the PHP version in composer.json to 7 and used PHP 8 features in the same commit. This breaks the whole idea of the composer.json.

Izet0004 commented 1 year ago

Same problem here..

If anyone want's a quick fix

Edit line 105 inside Entity.php and remove the "mixed" return type

This should not be taken as a permanent fix

cesar1983 commented 1 year ago

The problem with this library is that you don´t release versions. You must start releasing versions to avoid this situation.

DjThossi commented 1 year ago

Please tag branch dev-release/2.0.0 with tag 2.0.0

It will solve our problems. @PrintNodeLtd PLEASE!!!!