Printrbot / Printrhub

This is the public repository of the display and controller of our new 3D printer: Simple 2016.
http://printrbot.com/new-2016-simple/
35 stars 9 forks source link

Fix compilation issues #36

Closed pschuster closed 6 years ago

pschuster commented 6 years ago

I have updated PlatformIO to the latest versions:

I could reproduce compilation errors in both ESP and MK20 firmware. Those are minor issues. Looks like in ESP and Teensy core some bugs in C standard library implementations have been fixed that triggered some compilation errors.

I once implemented FasterWiFiClient as a fork of WiFiClient (ESP8266 core) to fix a specific timing bug that we had with CommStack. However, it's been a CommStack bug that once fixed rendered FasterWiFiClient useless. But I never removed that. Now, that the base class from ESP8266 core has gotten some major interface changes this class created compilation errors. As it's not used in the project, I just removed it.

Another issue has been the virtual keyboard that got some characters that don't seem to be part of the ASCII table (multi-char) but did not make any issues in earlier versions of the Teensy core. However, this might explain some issues I had with VirtualKeyboard before ;-). I just removed those characters. This might result in a strange keyboard layout. But VirtualKeyboard is not used at the moment we leave fixing that in #31.

eb6413b (fixing isnan in DataStore class) is the only fix that makes me think, though. As this never really worked correctly (as isnan makes no sense for single byte integer) I am not sure as this has some side effects on printing. But this is the only change that is related to the printing part, so we should make sure that material structures from the cloud always have the material temperature set. I am not sure if this is always the case, please @oddirmeyer check that!

Please try this new release. I had no chance to test this firmware on a printer. If everything works fine, we should merge the pull request.