search

Prinz23 / NZBGetPasswordDetector

14 stars 2 forks source link

urllib3 not a supported version? #4

Open famewolf opened 2 years ago

famewolf commented 2 years ago

Running your passworddetector on a fresh docker install of nzbget and am seeing the following:

Wed Nov 02 2022 02:37:19 | PasswordDetector: warnings.warn("urllib3 ({}) or chardet ({})/charset_normalizer ({}) doesn't match a supported " Wed Nov 02 2022 02:37:19 | PasswordDetector: /usr/lib/python3.9/site-packages/requests/init.py:102: RequestsDependencyWarning: urllib3 (1.26.7) or chardet (5.0.0)/charset_normalizer (2.0.7) doesn't match a supported version!

Prinz23 commented 2 years ago

On your system you have by requests lib unsupported (newer) versions of urlib3 and/or chardet/charset_normalizer installed.

This is not an issue with this script, it's an support issue of the used requests lib.

famewolf commented 2 years ago

Thank you for your reply. I am using the docker image of NZBGet from dockerhub and have verified it has python 3.9 installed in the image. I also include the lib from your github. Is this warning something I can ignore or is there a way to make it use the version in the lib folder in the scripts directory where NZBGetPasswordDetector.py is located?

Prinz23 commented 2 years ago

Normally calling: python -m pip install requests should install/downgrade the dependencies of requests lib.

famewolf commented 2 years ago

Sadly that will get "reset" every time the docker image is started/restarted. even with the warning the script says it was successful. Should I remove it?

Prinz23 commented 2 years ago

It's just a warning meaning requests was not tested with the new version and you can't report request bugs with it. But as long as all works you can ignore the warning.

famewolf commented 2 years ago

I was wrong...I found lines in file later indicating the script was being skipped after the versions didn't match so ended up removing the script. I hope at some point when you you upgrade perhaps you can make it work with the existing version in latest python (1.3.9) in the docker image or configure the script so it directly calls the functions from the included file perhaps by giving them unique names so it doesn't conflict with the newer versions. In any case thanks for providing a starting point. I'm still debating on nzbget and sabnzbd and think EVENTUALLY nzbget will be the obvious choice. The problem is right now so many built in functions of sabnzbd+ end up being 3rd party add on scripts that may or may not work with your current setup.