search

PrinzPizza42 / DeathMinigames

2 stars 0 forks source link

Migrate Death minigames into main plugin #64

Closed JonasFranke closed 1 month ago

JonasFranke commented 1 month ago

What is the current state? Is it able to be merged into the main plugin?

PrinzPizza42 commented 1 month ago

In my opinion, yes, the only thing missing right now is everything about the website and some testing with several people.

JonasFranke commented 1 month ago

If you want you can create a PR with your files

PrinzPizza42 commented 1 month ago

I will do that later today

PrinzPizza42 commented 1 month ago

What is the best way to add my file to the project? If i just copy all of them into the right folder the references for importing and so on wont be working properly

PrinzPizza42 commented 1 month ago

I also just remembered, that I need to change the naming of my folders from org.example.DeathMinigames to de.luca.DeathMinigames, I will finish and make a PR to my repository, and then we can continue merging the plugins.

PrinzPizza42 commented 1 month ago

Made the PR, just waiting for you to look over it.

JonasFranke commented 1 month ago

What is the best way to add my file to the project? If i just copy all of them into the right folder the references for importing and so on wont be working properly

prop. just copying and fixing the imports although most of them should still work if you fix the package path

JonasFranke commented 1 month ago

You can also add yourself to the codeowners file with the files you add