search

Prinzhorn / skrollr

Stand-alone parallax scrolling library for mobile (Android + iOS) and desktop. No jQuery. Just plain JavaScript (and some love).
http://prinzhorn.github.io/skrollr/
MIT License
18.53k stars 3.51k forks source link

Remove iOS Workaround #828

Open eerikson opened 7 years ago

eerikson commented 7 years ago

Due to iOS (for several versions now) actually supporting scroll events as expected, the workaround seems to be, ironically, causing other issues when it isn't necessary.

I've personally been able to get things working 100% when I go in and disable the hack myself, but is this something that can be turned off by default in a future release?

RyanRoberts commented 7 years ago

Would the following work for you?

<script>
  var s = skrollr.init({
    mobileCheck: function() {
      return false;
    }
  });
</script>
eerikson commented 7 years ago

Definitely works, I'm just hoping newcomers aren't turned off by comparatively wonky iOS support—the default legacy workaround included by mobileCheck -> true is unnecessary and makes things worse than the default behavior. And yes, I realize this is just an opinion!

I'd be happy to contribute if it can be decided how to proceed (ie, maybe mobileCheck only checks for older versions of iOS where the hack was required).