search

Prior99 / cah-fullformat-german

A german translation of cards against humanity, categorized and ink-friendly in full playing-card format. Written in LaTeX.
12 stars 4 forks source link

Sync with official fan translations #6

Closed Vankog closed 6 years ago

Vankog commented 6 years ago

status: done implementation of #2

Prior99 commented 6 years ago

Hi, what's the license of the official fan translations? Can we use them without mentioning?

Vankog commented 6 years ago
  1. It is the same license as the main game. Mentioning must be done.
  2. I mentioned them in the README.md for this reason
  3. That's one reason why I opened #5 as well
Vankog commented 6 years ago

I can see why you want to remove the "before" comments. I'll remove them. However, I'd like to stand up for keeping the "original" ones. These are the ones from the fan translations by Ballz and Raphael. I introduced them to have a mapping. Otherwise, some of their phrases that I changed for one reason or another, might be reintroduced in the future. I'd like to prevent this from happening. Especially, because they also added some German original phrases that don't show up in the engl. version.

Prior99 commented 6 years ago

Sounds good!

On Fri, Apr 13, 2018, 12:59 Daniel Mönch notifications@github.com wrote:

I can see why you want to remove the "before" comments. I'll remove them. However, I'd like to stand up for keeping the "original" ones. These are the ones from the fan translations by Ballz and Raphael. I introduced them to have a mapping. Otherwise, some of their phrases that I changed for one reason or another, might be reintroduced in the future. I'd like to prevent this from happening. Especially, because they also added some German original phrases that don't show up in the engl. version.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Prior99/cah-fullformat-german/pull/6#issuecomment-381101348, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbCdu-l0LCEDioWgLK4gBUV4szOb7j1ks5toIUmgaJpZM4TQh69 .

Vankog commented 6 years ago

better?

Prior99 commented 6 years ago

Yes. Accepted. Thanks for your contribution :)