search

Prior99 / mopidy-subidy

Mopidy extension for playing music from Subsonic servers.
BSD 3-Clause "New" or "Revised" License
30 stars 10 forks source link

Remove version range for py-sonic #25

Closed jonathanchristison closed 5 years ago

jonathanchristison commented 6 years ago

py-sonic stopped supporting python2 > 0.6.2 Using pip to install results in an error if this is not set

pip install . 
Processing /home/pi/mopidy-subidy
Collecting Mopidy>=2.0 (from Mopidy-Subidy==0.2.1)
  Using cached https://files.pythonhosted.org/packages/1e/1e/6a64a4a27bda7f025f397e0e11b53168dfc83d613605c1969581bc68f644/Mopidy-2.1.0-py2.py3-none-any.whl
Collecting Pykka>=1.1 (from Mopidy-Subidy==0.2.1)
  Using cached https://files.pythonhosted.org/packages/66/cd/89889a1b079385ce9c3e6adc447d20c2f77116c1fb08f65bb23a601be8cb/Pykka-1.2.1-py2.py3-none-any.whl
Collecting py-sonic>=0.6.1 (from Mopidy-Subidy==0.2.1)
  Using cached https://files.pythonhosted.org/packages/e7/ae/4a48ca9010d8f69714f01a223de66949cbe52c233d231479dcaabb4df1a7/py-sonic-0.7.2.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-mcMWRy/py-sonic/setup.py", line 21, in <module>
        from libsonic import __version__ as version
      File "libsonic/__init__.py", line 30, in <module>
        from .connection import *
      File "libsonic/connection.py", line 21, in <module>
        import urllib.request
    ImportError: No module named request

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-mcMWRy/py-sonic/
Prior99 commented 6 years ago

Hi, it's been one month since you opened this Pullrequest. Sorry for the delay, I just wanted to assure you that this project is by no means unmaintained, it's just that I was a bit busy these last days.

I agree with the fix of the version to 0.6.2, however there is another change in the code. Is it related?

jonathanchristison commented 6 years ago

Hi @Prior99 no problem! This was my bad, I'd continued hacking on the same branch to try and fix some issues with browsing by album artist and accidentally pushed (forgetting this PR was still outstanding). I'll try and solve #26 sometime soon.

I've reset my branch to only include the one fix that this PR was originally raised for

jonathanchristison commented 5 years ago

@Prior99 Is my reset branch sufficient or do you need more information? I think this will be affecting anyone using pip method of install

Prior99 commented 5 years ago

Sorry for the delay, I didn't get a notification after you pushed the new commit. I merged it. Thank you for your contribution and your patience.