Closed shff closed 1 year ago
I'm not 100% sure if this will work in the CI, though! If it does we can apply the same solution to native-image-diff
.
Amazing news! Thank you so much for the PR 🤩
What do you think @Prior99?
@shff But isn't this then always building an arm64
binary, which is likely not working on i386
architectures?! Maybe owe can build both sequentially and use lipo
to bundle them to a universal binary?
https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary
@fjaeger In travis.yml the Intel version is still built in line 58, so they would be built sequentially. Due to how install.js works, it requires different binaries for different architectures. So we need to build and provide two binaries for download anyway.
Sorry to bump this, but is anything currently stopping us from merging this? It would be great to see this getting released 😃
@Prior99 Is it only you who can merge PRs? or also @fjaeger?
@tujoworker Unfortunately, I cannot merge PRs here :-(
I was able to cross-compile for the M1 chip from an Intel machine with these commands:
I airdropped the file to an M1 computer and all tests passed.
Solves #45