PrismLauncher / PrismLauncher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once (Fork of MultiMC)
https://prismlauncher.org
GNU General Public License v3.0
5.67k stars 635 forks source link

Automatically add or suggest adding fix for Serialization security vulnerability #1463

Open the-vindex opened 1 year ago

the-vindex commented 1 year ago

Role

I play modded minecraft

Suggestion

When launching modpack on vulnerable versions, I want Prism to automatically add fixer mod for security vulnerabilty, see link below. Or warn me and ask for permissing to oneclick add that mod

Benefit

Security

This suggestion is unique

You may use the editor below to elaborate further.

See post here https://github.com/dogboy21/serializationisbad/blob/master/README.md

Ryex commented 1 year ago

I think I may have a idea for how this could work. if we maintained a list of known bad mod shas on the meta server we could flag them in a pre launch step. perhaps even suggest secure replacements? perhaps the mmpa would be willing to help maintain this?

the-vindex commented 1 year ago

What that project does is essentially having a patcher which is driven by config file, which lists vulenerable mods and classes to patch in a config file, which they update directly from github: https://github.com/dogboy21/serializationisbad/blob/master/serializationisbad.json

Steveplays28 commented 1 year ago

Serialization Is Bad is attached as a Java Agent, so perhaps a checkbox somewhere could be added to automatically download the latest version of SIB and add the JVM argument. Maybe the instance creation tab (and versions tab) could be a good place for this?