PrismLauncher / meta

Prism Launcher Metadata generation scripts
Microsoft Public License
16 stars 16 forks source link

Unstable Fabric Loader versions are marked as reccomended. #14

Closed modmuss50 closed 1 year ago

modmuss50 commented 1 year ago

The logic here is not correct: https://github.com/PrismLauncher/meta/blob/master/generateFabric.py#L72-L73

As seen here (at the time of writing): https://meta.fabricmc.net/v2/versions/loader loader 0.14.15 is not marked as stable, 0.14.14 should be the default version users install.

It seems my change made here: https://github.com/PrismLauncher/meta/commit/6f742903d06f885e76d909bc6e8859a1e13acf2a was lost during a refactor.

Scrumplex commented 1 year ago

Yep. This was lost during a refactor. I will fix this!

Scrumplex commented 1 year ago

Fixed in 9d6c195c47948042bbb23394229843d2bd8adb9a

Scrumplex commented 1 year ago

Also triggered a manual update to our meta: https://github.com/PrismLauncher/meta-launcher/commit/f6da648794beea603be0bd3a496dba1c386774e7

modmuss50 commented 1 year ago

Perfect, many thanks for resolving this so quickly 👍