PrismLauncher / meta

Prism Launcher Metadata generation scripts
Microsoft Public License
16 stars 17 forks source link

Quilt versions got incorrectly "re-published" on 01.05.2023 #18

Closed SplendidAlakey closed 1 year ago

SplendidAlakey commented 1 year ago

Operating System

Windows

Version of Prism Launcher

6.3

Version of Qt

Qt 6.4.2

Description of bug

Today, on 01.05.2023, Quilt Loader versions got "re-published" in a weird manner. First of all, not all versions of the loader are present. Second, versions are displayed in reverse, e.g. an old 0.16.x branch is above the latest 0.19.x. And lastly, all of them are marked as released today.

Initially, I contacted Quilt about it, but was told, that Quilt doesn't even provide the publishing date, so it didn't seem like the issue on their end. I then checked the standalone Quilt installer and that one indeed does not have the same issue.

image

Steps to reproduce

Simply open the instance creation window and select Quilt as your modloader. Alternatively use an already existing instance and use the "Edit" function.

Suspected cause

No response

This issue is unique

Scrumplex commented 1 year ago

Release timestamps are determined by the Last-Modified date of the JAR files or, if that's not present, by the oldest modification time inside the JAR files. Relevant code: https://github.com/PrismLauncher/meta/blob/f7020ba176d305c663a5d5b916502f075600c10e/updateQuilt.py#L70-L89

Akarys42 commented 1 year ago

Please do not rely on Last-Modified, it makes no guarantee when it comes to publication times.

Scrumplex commented 1 year ago

Please do not rely on Last-Modified, it makes no guarantee when it comes to publication times.

Is there a lightweight alternative? Our metadata needs a timestamp so that it can be sorted and displayed in the launcher later. Is this perhaps something that could be added to the metadata itself?

Scrumplex commented 1 year ago

Hmm. After examining the code in https://github.com/QuiltMC/update-quilt-meta, it looks like this is going to be a bit harder than expected, as it fully relies on the artifacts in the maven repo.

Maybe the maven repo can be extended by adding a json file with extra metadata about a particular file?

Scrumplex commented 1 year ago

bd1326daf28da56a825d96cac01e5194696fb1ed makes it use the JAR contents now. Not a nice solution though, as that will mean it will be redownloaded each time.

Scrumplex commented 1 year ago

Should be fixed now. Check https://github.com/PrismLauncher/meta-launcher/commit/0f51db0e94ee7f63b25ccd156f3ef3702ce0ad0e

I don't really like this solution, though. Having an actual timestamp in the metadata would be nicer.

DioEgizio commented 1 year ago

I think quilt should offer the timestamp in the metadata, this solution is kinda hacky