when noapplet is used with legacyLaunch, AbstractLauncher::gameArgs is always empty (or just contains --demo) because when generating the meta, minecraftArguments are removed, which causes the there to be no params entry for it. There is some legacy code in MojangVersionFormat.cpp that might be meant to handle this but at current it is almost entirely unused. This pr simply removes the code that nullified the default arguments.
I tested this change in a couple versions, "noapplet" with a1.2.6 causes some IndexOutOfBounds exception with or without minecraftArguments set, and with this fix b1.7.3 and 1.3.2 get sessionIds and usernames passed through with noapplet, which in turn lets legacyFixes find skins, whereas without minecraftArguments set it behaves how I laid out in the original issue.
Scrumplex
commented
8 months ago
discussion on discord resolves https://github.com/PrismLauncher/PrismLauncher/issues/1580
when noapplet is used with legacyLaunch,
AbstractLauncher::gameArgsis always empty (or just contains--demo) because when generating the meta, minecraftArguments are removed, which causes the there to be no params entry for it. There is some legacy code in MojangVersionFormat.cpp that might be meant to handle this but at current it is almost entirely unused. This pr simply removes the code that nullified the default arguments.I tested this change in a couple versions, "noapplet" with a1.2.6 causes some IndexOutOfBounds exception with or without minecraftArguments set, and with this fix b1.7.3 and 1.3.2 get sessionIds and usernames passed through with noapplet, which in turn lets legacyFixes find skins, whereas without minecraftArguments set it behaves how I laid out in the original issue.