Support 1.18 and newer chunks in examples

PrismarineJS / bedrock-protocol

Minecraft Bedrock protocol library, with authentication and encryption

https://prismarinejs.github.io/minecraft-data/?v=bedrock_1.17.10&d=protocol

MIT License

309 stars 72 forks source link

Support 1.18 and newer chunks in examples #158

Open TaylorDale opened 2 years ago

TaylorDale commented 2 years ago

When I run the chunk decoding example in clientInternal.js on a 1.18 server the chunk provider stays blank. Stepping through the code executing it seems like packet.sub_chunk_count === -1 which causes most of the code in networkDecodeNoCache() to be skipped.

This line is also getting called in ChunkColumn.js which is causing unintended console output, not sure if it is of any relevance: console.debug('[wp] Read ', extra, 'bytes')

extremeheat commented 2 years ago

Caves and cliffs update chunks are not currently supported in bedrock-provider

TaylorDale commented 2 years ago

Got it, cheers 👍

Bluebotlabz commented 1 year ago

Would it work with the updated latest version of bedrock-provider?

(assuming that CI actually worked with it)

extremeheat commented 1 year ago

The breaking change with bedrock-protocol 3.0 is move of chunk implementation into prismarine-chunk. 1.18.30+ is not supported per issue in pchunk https://github.com/PrismarineJS/prismarine-chunk/issues/182