search

PrismarineJS / bedrock-protocol

Minecraft Bedrock protocol library, with authentication and encryption
https://prismarinejs.github.io/minecraft-data/?v=bedrock_1.17.10&d=protocol
MIT License
288 stars 68 forks source link

Tick Sync is now deprecated #504

Closed w0ahL closed 2 weeks ago

w0ahL commented 3 weeks ago

First, Tick Sync is now deprecated in v1.21.0

Second, no actual clients used this packet and it was never required in apart of the login sequence.

A PR in Mojang's Bedrock Protocol Docs suggests the packet being deprecated.

extremeheat commented 3 weeks ago

Hi,

We don't just support the latest version, but many versions. If the vanilla client is doing something on old clients it seems to make sense to me to mirror it as best to vanilla 1:1 as possible. Maybe this should be behind a feature flag.

w0ahL commented 3 weeks ago

Well i'm aware your supporting multiple different versions, but I do not know which or any versions this tick sync packet was used on, i know that 1.20.80 didnt use it anymore.

w0ahL commented 3 weeks ago

Do you just want me to add a check to do 1.20.80 and less for the tick sync packet?

extremeheat commented 3 weeks ago

Yes, putting behind a version check seems good

w0ahL commented 3 weeks ago

Checks passed, lmk if its good to you

extremeheat commented 2 weeks ago

Thanks, LGTM

extremeheat commented 2 weeks ago

We should move this to using features (our current version checking code was written before we had those) but this will require some other changes to the code to instantiate minecraft-data, so we can work on that separately at some point.