search

PrismarineJS / flying-squid

Create Minecraft servers with a powerful, stable, and high level JavaScript API.
https://prismarinejs.github.io/flying-squid/
MIT License
531 stars 99 forks source link

Use prismarine-registry #613

Open rom1504 opened 1 year ago

rom1504 commented 6 months ago

It's used now but maybe should be instantiated by server x version

Pandapip1 commented 6 months ago

Probably worth closing this issue and making a new one then?

rom1504 commented 6 months ago

No it's still valid

Pandapip1 commented 6 months ago

No it's still valid

Okay. Is there any advantage to using a single instance? What if the server is multi-version; wouldn't it make sense for per-client plugins to use a registry instance that uses the player version, not the union of the server versions?

rom1504 commented 6 months ago

The version/player consideration is independent from the consideration of having the registry be stateful or not.

The benefit of having the registry be stateful is the ability to change the parameters sent to all clients, for example by loading a config file