Closed zardoy closed 10 months ago
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
Packages | Version | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|---|
exit-hook | 2.2.1 | None | +0 |
4.83 kB | sindresorhus |
🚮 Removed packages: mkdirp@2.1.6
Overall looks good, but left some comments
overall lgtm, merged
/makerelease
Depends on https://github.com/PrismarineJS/node-minecraft-protocol/pull/1254
fixes #491
Usage:
Both esbuild and webpack needs Node.js modules polyfilling.
module: { parser: { javascript: { commonjsMagicComments: true } } }
First of all, I'm really sorry for the delay, I wish I could do it early.
Anyway, right now I decided to squash all changes from here into one commit.
Will try to provide a brief overview of the changes I made here in comments.
Refactored plugin loading so its compatible with webpack (at least I tested the first version of it) and esbuild that I use currently.
I did initially a huge refactor by adding types, but I reverted them so its easier to review. Anyway, feel free to ask any questions