Add 1.16.5 support and future-proof version system - Githubissues

PrismarineJS / flying-squid

Create Minecraft servers with a powerful, stable, and high level JavaScript API.

https://prismarinejs.github.io/flying-squid/

MIT License

531 stars 99 forks source link

Add 1.16.5 support and future-proof version system #645

Closed Pandapip1 closed 6 months ago

Pandapip1 commented 6 months ago

~~Blocked by: https://github.com/PrismarineJS/minecraft-data/pull/823; new version of node-minecraft-data~~ Done!

Forked from #599. The author appears to have gone AWOL.

~~The goal of this PR is to add version support up to 1.18.2~~

Never mind. That will take a lot more time. For now, this has stable 1.16.5 support.

Fixes https://github.com/PrismarineJS/flying-squid/issues/447 and the following unreported minor issues:

Duplicate interaction registration on startup
Error when a client quits before chunks are loaded
Error when a client quits, at all

Closes #599

rom1504 commented 6 months ago

Thank you for working on that.

I left some comments, mostly about following the same conventions we now follow in other PrismarineJS projects and I think will help here.

Pandapip1 commented 6 months ago

Sounds good. There's a test case that's failing. I don't know why. It works on my machine :shrug:

rom1504 commented 6 months ago

left some more comments but most things look good besides that

rom1504 commented 6 months ago

would be good if we can finally make progress on version supports for flying squid

Pandapip1 commented 6 months ago

We've got a green!

rom1504 commented 6 months ago

Left one comment about that onItemPlace

rom1504 commented 6 months ago

Thanks for the PR.

There's a pretty big pile of new versions to get this to current: 1.17, 1.18, 1.19, 1.20 You can look at corresponding mineflayer PR to know what needs to be changed / implemented

rom1504 commented 6 months ago

/makerelease