search

PrismarineJS / flying-squid

Create Minecraft servers with a powerful, stable, and high level JavaScript API.
https://prismarinejs.github.io/flying-squid/
MIT License
535 stars 101 forks source link

1.17.1 support #650

Open Pandapip1 opened 9 months ago

Pandapip1 commented 9 months ago

Blocked by https://github.com/PrismarineJS/diamond-square/pull/15, https://github.com/PrismarineJS/prismarine-provider-anvil/issues/73.

rom1504 commented 8 months ago

Looks like tests are passing.

Do things seem to work?

Pandapip1 commented 8 months ago

Looks like tests are passing.

Do things seem to work?

THINGS DO NOT WORK. Particularly, world saving is completely borked and sometimes the server crashes when trying to send chunk packets (all to do with the palette set to null error).

rom1504 commented 8 months ago

I made https://github.com/PrismarineJS/prismarine-provider-anvil/pull/74 which I think should fix this anvil problem

Can you check if that helps the error you were seeing @Pandapip1 ?

socket-security[bot] commented 8 months ago

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/prismarine-provider-anvil@2.7.0

View full report↗︎

Pandapip1 commented 8 months ago

I'm still getting the following error, even after updating:

January 14th 2024, 16:30:13 [ERROR]: -------------------------------
January 14th 2024, 16:30:13 [ERROR]: Please report this flying-squid! This is bug (mabye)
January 14th 2024, 16:30:13 [ERROR]: Something went wrong!
January 14th 2024, 16:30:13 [ERROR]: Error: TypeError: this.sectionMask.toLongArray is not a function
    at ChunkColumn.getMask (/home/gavin/repos/flying-squid/node_modules/prismarine-chunk/src/pc/1.17/ChunkColumn.js:244:31)
    at /home/gavin/repos/flying-squid/src/lib/plugins/world.js:188:23
    at Entity.behavior (/home/gavin/repos/flying-squid/src/lib/behavior.js:24:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async player.login (/home/gavin/repos/flying-squid/src/lib/plugins/login.js:222:5)
    at async Server.<anonymous> (/home/gavin/repos/flying-squid/src/lib/plugins/login.js:29:7)
January 14th 2024, 16:30:13 [ERROR]: Report this error here: https://github.com/PrismarineJS/flying-squid/issues
January 14th 2024, 16:30:13 [ERROR]: -------------------------------
January 14th 2024, 16:30:13 Server shutting down...
rom1504 commented 8 months ago

ok that's a different error than the palette

rom1504 commented 8 months ago

would be great to have a test showing this, would make it faster to debug

rom1504 commented 7 months ago

https://github.com/PrismarineJS/prismarine-provider-anvil/issues/75 / https://github.com/PrismarineJS/prismarine-provider-anvil/issues/73 is the blocker here

privt00 commented 6 months ago

hey i think i made progress

getting now this error

March 29th 2024, 18:47:08 [ERROR]: Error: TypeError: this.skyLightMask.toLongArray is not a function at ChunkColumn.dumpLight (C:\Users\Noah\Documents\mclient\node_modules\prismarine-chunk\src\pc\1.17\ChunkColumn.js:379:61) at C:\Users\Noah\Documents\mclient\src\lib\plugins\world.js:245:20 at Entity.behavior (C:\Users\Noah\Documents\mclient\fly-high\src\lib\behavior.js:24:14) at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

after world safe in 1.17.1 but yeah im tryng to fix it at moment i just dont know if its has somthing to do whit the anvil or just whit the chunkColumn.js

privt00 commented 6 months ago

i also try fixing redstone like piston activated and all stuff

privt00 commented 6 months ago

i fixed this error

privt00 commented 6 months ago

just need to fix the lightnigs

privt00 commented 6 months ago

ok made now the 1.17.1 support

privt00 commented 6 months ago

oh no relised world dosnt safe you just can join and build but nothing gets saved

privt00 commented 6 months ago

@rom1504 in which file is the savin logik?

rom1504 commented 6 months ago

This repo https://github.com/PrismarineJS/prismarine-provider-anvil/issues/73