Put code in common with nmp

PrismarineJS / minecraft-classic-protocol

[En][de]code Minecraft 0.30c packets

MIT License

8 stars 2 forks source link

Put code in common with nmp #1

Open rom1504 opened 8 years ago

rom1504 commented 8 years ago

Once we get this project off the ground, I think it would be a good idea to figure out a way to make a module that runs both node-minecraft-protocol and minecraft-classic-protocol.

[x] minecraft classic protocol data into minecraft-data
[ ] minecraft classic code itself into nmp

ghost commented 8 years ago

And we should also put classic protocol data in minecraft-data

rom1504 commented 8 years ago

no, definitely not a submodule.

rom1504 commented 8 years ago

"Put code in common with nmp" is deliberately vague because we need to figure out what is the right way to do it.

ghost commented 8 years ago

@rom1504 alright, sorry. I was thinking of having mcp (minecraft-classic-protocol) still a github repo but using it as a git submodule then in the arguments of node-minecraft-protocol choose if the user wants nmp or mcp then the index.js exports the correct one.

rom1504 commented 8 years ago

Now that stuff work, I'll try to figure out how/if this can be merged with nmp.

Doesn't seem very obvious because createClient and createServer are very different.