PrismarineJS / minecraft-data

Language independent module providing minecraft data for minecraft clients, servers and libraries.
https://prismarinejs.github.io/minecraft-data
661 stars 222 forks source link

[1.20.2] Incorrect recipes, and inconsistent shape format #797

Open ratquaza opened 11 months ago

ratquaza commented 11 months ago

Noticed that the crafting table recipe is wrong - describes it as an L shape instead of a square:

    {
      "inShape": [
        [ 23, 23, 23 ], 
        [ 23, null, null ]
      ],
      "result": {
        "id": 278,
        "count": 1
      }
    }

Haven't found any other incorrect recipes, but there may be more.

Secondly, there's an inconsistency with the format of recipe shapes - some recipes define each array as a "row" in the crafting grid, e.g Sandstone Wall:

      "inShape": [
        [ 169, 169, 169 ],
        [ 169, 169, 169 ]
      ]

image

But then for a Redstone Torch, each array is a "column":

      "inShape": [
        [
          635,
          807,
          null
        ]
      ]

image

wgaylord commented 10 months ago

This should be fixed by the same fix that fixed #804 But I will double check these recipes

wgaylord commented 10 months ago

Can confirm that this is now fixed.

Crafting table's recipe is

"278": [ { "inShape": [ [ 23, 23 ], [ 23, 23 ] ], "result": { "id": 278, "count": 1 } } ]

Sandstone Wall's recipe is

"387": [ { "inShape": [ [ 169, 169, 169 ], [ 169, 169, 169 ] ], "result": { "id": 387, "count": 6 } } ]

And the redstone torch recipe is

[ { "inShape": [ [ 635 ], [ 807 ] ], "result": { "id": 636, "count": 1 } } ]