search

PrismarineJS / minecraft-data

Language independent module providing minecraft data for minecraft clients, servers and libraries.
https://prismarinejs.github.io/minecraft-data
620 stars 214 forks source link

fix: dimension is available from 1.16.2 #877

Closed zardoy closed 3 weeks ago

zardoy commented 1 month ago

dimension data in the login packet is from 1.18 (pushing to fix the external code), however, I didn't test it with mineflayer, most probably this needs to be updated: https://github.com/PrismarineJS/mineflayer/blob/2ff9919760d714be57dcb678f8ab5ecff69f5fee/lib/plugins/game.js#L55

extremeheat commented 1 month ago

Why would it need to be updated?

zardoy commented 1 month ago

Why would it need to be updated?

Because mineflayer is not the only project using minecraft-data eg this is important for flying-squid and a few other projects

extremeheat commented 1 month ago

Yes, I am specifically referring to your comment mentioning

dimension data in the login packet is from 1.18 (pushing fix the external code), however I didn't test it with mineflayer, most probably this needs to updated: https://github.com/PrismarineJS/mineflayer/blob/2ff9919760d714be57dcb678f8ab5ecff69f5fee/lib/plugins/game.js#L55

Please elaborate on the change needed

rom1504 commented 3 weeks ago

Re open if you want to finish it

zardoy commented 3 weeks ago

Re open if you want to finish it

I won't be able to reopen it if maintainer closes it

zardoy commented 3 weeks ago

@rom1504 has someone ever reopened their pr after you closed it? i believe it's not possible

rom1504 commented 3 weeks ago

You can say to re-open and I will if you want to finish it. Do you ?