Implement protodef-yaml for mcpc

PrismarineJS / minecraft-data

Language independent module providing minecraft data for minecraft clients, servers and libraries.

https://prismarinejs.github.io/minecraft-data

651 stars 222 forks source link

Implement protodef-yaml for mcpc #886

Closed extremeheat closed 2 months ago

extremeheat commented 3 months ago

Implement protodef-yaml for mcpc
Support pc in incrementVersion script

rom1504 commented 3 months ago

it does look pretty good

do you think we can do anything about older versions?

rom1504 commented 3 months ago

I think we should update docs for explaining contributors where they need to update the protocol info

rom1504 commented 2 months ago

sorry for the delay in reviewing, I've been pretty busy in last months.

This looks pretty good!

One last thing I am noticing is the addition of default void in many places; which seems incorrect to me. For most switches the default is not void. There is no default! In protodef it means it will fail if value is not among the specified choices. Could you fix that?