PrismarineJS / minecraft-wiki-extractor

Extract structured data from the minecraft wiki
10 stars 11 forks source link

Do we want to extract the icons from the wiki? #29

Open uncovery opened 4 years ago

uncovery commented 4 years ago

I have written a code that extracts the icons from the wiki as well. It downloads the individual block icons and creates a CSS for the item sprites as well. With the help of imagick or similar we could create individual item images.

Since all the regex and so on already exists here, it would be easy to implement if we wanted.

This is relevant because there is no 1:1 link for all items and block in the JSON data to the image files in minecraft-assets.

Let me know.

rom1504 commented 4 years ago

Doesn't minecraft assets (and minecraft jar extractor) do this better ?

On Thu, May 14, 2020, 07:49 Uncovery notifications@github.com wrote:

I have written a code that extracts the icons from the wiki as well. It downloads the individual block icons and creates a CSS for the item sprites as well. With the help of imagick or similar we could create individual item images.

Since all the regex and so on already exists here, it would be easy to implement if we wanted.

Let me know.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/minecraft-wiki-extractor/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437UXJGUDUVKG4DJEX73RROA57ANCNFSM4NAL4M6Q .

uncovery commented 4 years ago

There are specifc items that do not exist in the minecraft assets and won't ever, specifically full icons of blocks. The mc-assets rather has the top/bottom/etc images, but no 3D block icons such as this one:

https://gamepedia.cursecdn.com/minecraft_gamepedia/thumb/b/be/Acacia_Log_Axis_Y_JE5_BE3.png/30px-Acacia_Log_Axis_Y_JE5_BE3.png

mc-assets in this case has only the top and side view: https://github.com/PrismarineJS/minecraft-assets/blob/master/data/1.15.2/blocks/acacia_log.png https://github.com/PrismarineJS/minecraft-assets/blob/master/data/1.15.2/blocks/acacia_log_top.png

Further, many blocks do not even have an image file that corresponds to the itemname if you want to link one specific item (such as "microsoft:tall_grass ") to the entry in the mc-data block Json. acacia_log is a lucky one, we would at least have the 2D side view, but others with more "versions" do not have any file that corresponds to the itemname, see sweet_berry_bush, tall_grass and many more.

rom1504 commented 4 years ago

These icons are not provided by mojang but created by the wiki users ?

On Thu, May 14, 2020, 09:19 Uncovery notifications@github.com wrote:

There are specifc items that do not exist in the minecraft assets and won't ever, specifically full icons of blocks. The mc-assets rather has the top/bottom/etc images, but no block icons such as this one:

https://gamepedia.cursecdn.com/minecraft_gamepedia/thumb/b/be/Acacia_Log_Axis_Y_JE5_BE3.png/30px-Acacia_Log_Axis_Y_JE5_BE3.png

mc-assets in this case has only the top and side view:

https://github.com/PrismarineJS/minecraft-assets/blob/master/data/1.15.2/blocks/acacia_log.png

https://github.com/PrismarineJS/minecraft-assets/blob/master/data/1.15.2/blocks/acacia_log_top.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/minecraft-wiki-extractor/issues/29#issuecomment-628440819, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437RKLLNBKID35JIPJFLRROLQRANCNFSM4NAL4M6Q .

uncovery commented 4 years ago

Frankly I have no idea. But as of now, the Wiki is the only place where I can get them from.

rom1504 commented 4 years ago

Are these icons present in the game ?

On Fri, May 15, 2020, 01:46 Uncovery notifications@github.com wrote:

Frankly I have no idea. But as of now, the Wiki is the only place where I can get them from.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/minecraft-wiki-extractor/issues/29#issuecomment-628943954, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437W7JJZAN52NB4WAYT3RRR7GXANCNFSM4NAL4M6Q .

uncovery commented 4 years ago

I would think so, they are the ones that you see in your inventory. But I do not know if they are "assembled" for display from the textures or if the full icon is stored somewhere.

Karang commented 4 years ago

The icons for the blocks are created at game initialization using the in-game renderer.