search

PrismarineJS / mineflayer-collectblock

A simple utility plugin for Mineflayer that add a higher level API for collecting blocks.
MIT License
39 stars 25 forks source link

Reference block patch #53

Closed u9g closed 2 years ago

rom1504 commented 3 years ago

let's rebase and merge ?

rom1504 commented 3 years ago

last call

is this any good ?

TheDudeFromCI commented 3 years ago

@rom1504 I believe this PR just needs to be tested, now. It was a fairly big bug patch if I recall correctly. Already lived through two different draft PRs and all that. I just pushed the changes that @SeanMcCord suggested to help move things along. If everything works in-game, this PR should be ready to merge.

rom1504 commented 3 years ago

Let's give this PR another week then close it

ytcalifax commented 2 years ago

Will this ever get merged, the package is pretty broken as it is now...

rom1504 commented 2 years ago

@ytcalifax absolutely if someone decides to take the time to test it and report it works

rom1504 commented 2 years ago

went with the other pr