search

PrismarineJS / mineflayer-navigate

mineflayer plugin which gives bots a high level 3d navigating API using A*
59 stars 22 forks source link

Refactored into separate findPath and walk functions #13

Closed vogonistic closed 11 years ago

vogonistic commented 11 years ago

I'm open to suggestions to changes, but basically the functionality in bot.navigate.to has been split into two functions (bot.navigate.findPath and bot.navigate.walk). bot.navigate.to still exists, but uses findPath and walk.

Other:

rom1504 commented 11 years ago

Nice :) Maybe it would be possible to let the events if no callback is given. I don't need the events but someone might want to use them, I don't know, what do you think ?

rom1504 commented 11 years ago

I think this PR solve issue #10 , #11 and #12

vogonistic commented 11 years ago

The events still exists as you expect in the high level API (bot.navigate.to). I just couldn't make up my mind on the events in the lower level interface.

I think I'd like to hear superjoe30's thinking on this since if he doesn't pull it, I'm stuck with maintaining a fork =)

rom1504 commented 11 years ago

Oh ok, i read the code again, I see it. I think it's good that way, let's wait for superjoe30 then yes :)

andrewrk commented 11 years ago

This looks great. Let me play around with it a little bit and then I'm going to merge it.