search

PrismarineJS / mineflayer-pathfinder

Pathfinding plugin that gives bot the ability to go from A to B
MIT License
218 stars 67 forks source link

Promisify #89

Closed TheDudeFromCI closed 3 years ago

TheDudeFromCI commented 3 years ago

Given that the Mineflayer codebase is now using Promises instead of callbacks, it would make sense for all official Mineflayer plugins to also move in that direction.

Karang commented 3 years ago

Sure. As far as the api is concerned, there will be very little change as most of it is sync anyway. But it makes sense to use the promise versions of the calls to mineflayer's api.

TheDudeFromCI commented 3 years ago

Yeah, it's mostly just a matter of consistency more than anything. It's 95% of the way there already.

u9g commented 3 years ago

done, pls close