search

PrismarineJS / mineflayer-pvp

Adds support for basic PVP and PVE to Mineflayer bots.
MIT License
51 stars 19 forks source link

Promisify #24

Closed TheDudeFromCI closed 3 years ago

TheDudeFromCI commented 3 years ago

Given that the Mineflayer codebase now uses promises, all Mineflayer plugins should also more in that direction.

SeanMcCord commented 3 years ago

What exactly would this change look like? I think one approach would be to make attack return a promise that is resolved when the target has died/teleported/despawned/disconnected.

TheDudeFromCI commented 3 years ago

What exactly would this change look like? I think one approach would be to make attack return a promise that is resolved when the target has died/teleported/despawned/disconnected.

That's a good idea. It would be very useful.

u9g commented 3 years ago

This is more of a new feature then a requirement for making this package promisified, this package is already promisified, it's fine how it is now, its meant to be run, and you can check it's status while it's running. I think this should be closed and reopened as a feature request