search

PrismarineJS / mineflayer

Create Minecraft bots with a powerful, stable, and high level JavaScript API.
https://prismarinejs.github.io/mineflayer/
MIT License
4.96k stars 904 forks source link

windowType in 1.8 is a string #450

Closed roblabla closed 4 years ago

roblabla commented 8 years ago

https://github.com/PrismarineJS/mineflayer/search?utf8=%E2%9C%93&q=windowType http://wiki.vg/Inventory http://wiki.vg/index.php?title=Protocol&oldid=7368#Open_Window

We should change all references to windowType to a "minecraft:chest","minecraft:crafting_table"...

rom1504 commented 8 years ago

https://github.com/PrismarineJS/mineflayer/blob/ae7b67bad1e4e6c0a2bbd8c334d02f32993eb0db/lib/plugins/inventory.js#L220 where is window.type set ?

roblabla commented 8 years ago

https://github.com/PrismarineJS/prismarine-windows/blob/master/lib/windows.js#L48 https://github.com/PrismarineJS/mineflayer/blob/ae7b67bad1e4e6c0a2bbd8c334d02f32993eb0db/lib/plugins/inventory.js#L416

there

Karang commented 4 years ago

done in https://github.com/PrismarineJS/mineflayer/pull/968