PrismarineJS / mineflayer

Create Minecraft bots with a powerful, stable, and high level JavaScript API.
https://prismarinejs.github.io/mineflayer/
MIT License
4.95k stars 904 forks source link

Cannot move into portal blocks. #709

Closed derjp closed 4 years ago

derjp commented 6 years ago
plexigras commented 6 years ago

https://github.com/PrismarineJS/minecraft-data/search?q=%22Nether+Portal%22&unscoped_q=%22Nether+Portal%22

good find it should be "boundingBox": "empty" not "boundingBox": "block"

rom1504 commented 6 years ago

indeed. We need manual changes file (.json) to be able to manually fix these things.

PitPanda1 commented 6 years ago

I had the same problems with moving through / into nether portals in the navigate plugin
https://github.com/PrismarineJS/mineflayer-navigate/issues/35

rom1504 commented 6 years ago

That's the solution https://github.com/PrismarineJS/minecraft-data/issues/207

On Tue, Aug 28, 2018, 08:05 PitPanda1 notifications@github.com wrote:

I had the same problems with moving through / into nether portals in the navigate plugin

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/mineflayer/issues/709#issuecomment-416462107, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPN_vgoxfM85rsa4BU3569BVwhGYL9Pks5uVN2ygaJpZM4WER9n .

ahibbe commented 6 years ago

Hello, I'm very new here and have exactly the same problem as in the headline. It would be nice if you can give a few more bullet points. So far, as a beginner I found everything quite conclusive, but unfortunately I do not understand this solution:

'In a manual_overwrite / version dir Then make circle ci generate the blocks.json file and Co from this (use lodash merge for this)'

Thank you

rom1504 commented 6 years ago

the solution is to edit the bounding box of the portal block from "boundingBox": "block" to "boundingBox": "empty" in blocks.json If you want this to work right now, you can do this in node_modules/minecraft-data/data/pc/1.12/blocks.json . Or you can use version 1.13 which doesn't have this problem.

We will need a better solution to fix this long term.

Karang commented 4 years ago

Seems it was fixed in every version but 1.8:

https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.8/blocks.json#L2391

https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.9/blocks.json#L2318 https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.10/blocks.json#L2318 https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.12/blocks.json#L2259 https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.13/blocks.json#L5193 https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.14.4/blocks.json#L5557

Karang commented 4 years ago

It is now fixed also for 1.8 (and all versions)