search

PrismarineJS / node-minecraft-protocol-forge

Plugin to add FML/Forge client support (including auto-versioning) to node-minecraft-protocol
54 stars 18 forks source link

HandshakeReset handler #21

Closed murilopereirame closed 2 years ago

murilopereirame commented 2 years ago

Problem

Into Bungee servers, when happens the transaction between a vanilla and a modded server the protocol doesn't handle the Handshake reset.

Solution

Added HandshakeReset to the handshake lifecycle, writing the prop forgeHandshakeReset as true when happens a reset and sets forgeHandshakeState as FMLHandshakeClientState.START to restart the Handshake lifecycle.

rom1504 commented 2 years ago

does it work? for what versions?

murilopereirame commented 2 years ago

Tested and working with those settings

forgeMods: [
        { modid: "minecraft", version: "1.12.2" },
        { modid: "mcp", version: "9.42" },
        { modid: "FML", version: "8.0.99.99" },
        { modid: "Forge", version: "14.23.5.2860" }
]
rom1504 commented 2 years ago

Hey @rob9315 could you review this one ?

rob9315 commented 2 years ago

seems alright to me