PrismarineJS / node-mojangson

A mojangson parser written in node.js
17 stars 9 forks source link

mojangson vs node-mojangson #3

Closed deathcap closed 8 years ago

deathcap commented 8 years ago

The readme example uses the module name "mojangson"

var mojangson=require("mojangson");

but it is published as "node-mojangson":

https://www.npmjs.com/package/node-mojangson

Could be reconciled by updating the readme example to use node-mojang or republishing as mojangson. I'd favor the latter, https://www.npmjs.com/package/mojangson is available and NPM recommends against node- prefix naming in modules because it is implied: (note that the GitHub repository could still stay named as node-mojangson, since the context is less clear)

https://www.npmjs.com/package/node-mojangson

rom1504 commented 8 years ago

Yeah I meant to publish it as mojangson, and apparently didn't. What should I do about https://www.npmjs.com/package/node-mojangson though ? Just let it online like that ? Wouldn't that be confusing ?

rom1504 commented 8 years ago

Well I followed the advice at http://stackoverflow.com/a/28841779 and did: npm deprecate node-mojangson@"<=0.1.1" "WARNING: This project has been renamed to mojangson. Install using mojangson instead."

Republishing as mojangson.

deathcap commented 8 years ago

Thanks!