PrismarineJS / prismarine-nbt

An NBT parser for node-minecraft-protocol
93 stars 29 forks source link

Allow zigzag encoded varints to be read up to 64bits #74

Closed extremeheat closed 1 year ago

extremeheat commented 1 year ago

Fix https://github.com/PrismarineJS/bedrock-protocol/issues/436

readSignedVarInt is supposed to allow zigzag encoded varints up to 32bits in length. It seems some servers can incorrectly write 64bit values here which will lead to precision-related data loss, but the vanilla client allows for that data loss so I've increased the allowed assertion.

rom1504 commented 1 year ago

/makerelease