PrismarineJS / prismarine-physics

Provide the physics engine for minecraft entities
MIT License
35 stars 41 forks source link

Exception thrown while picking up exp points #17

Closed metroyanno closed 4 years ago

metroyanno commented 4 years ago

I get the following exception that crashes mineflayer. So, what's happened: bot killed a creeper and got exp points, after that the bot crashed and every time it joins the server it crashes again

bot/node_modules/prismarine-physics/index.js:599
    this.depthStrider = boots && boots.nbt.value.Enchantments && boots.nbt.value.Enchantments.some(x => x.id === mcData.enchantmentsByName.depth_strider.id)
                                           ^

TypeError: Cannot read property 'value' of null
    at new PlayerState (bot/node_modules/prismarine-physics/index.js:599:44)
    at Timeout.doPhysics [as _onTimeout] (bot/node_modules/mineflayer/lib/plugins/physics.js:61:32)
    at listOnTimeout (internal/timers.js:549:17)
    at processTimers (internal/timers.js:492:7)
IdanHo commented 4 years ago

This was fixed in #16, @rom1504 you might want to create a release

rom1504 commented 4 years ago

@IdanHo only thing to do to create a release is to push a "Release x.y.z" commit containing package.json and history.md change. If you create a pull request with that we only have to press "rebase and merge" and it's done. Could you do it?

On Sun, Aug 16, 2020, 13:36 Idan Horowitz notifications@github.com wrote:

This was fixed in #16 https://github.com/PrismarineJS/prismarine-physics/pull/16, @rom1504 https://github.com/rom1504 you might want to create a release

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/prismarine-physics/issues/17#issuecomment-674515618, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437VLARQR23O6TMSYDITSA7AEHANCNFSM4QAZB5GQ .

IdanHo commented 4 years ago

yep, see #18

IdanHo commented 4 years ago

@metroyanno all you have to do now is update your prismarine-physics