search

PrismarineJS / prismarine-physics

Provide the physics engine for minecraft entities
MIT License
35 stars 39 forks source link

Add entity collisions #54

Closed Chitasa closed 1 year ago

Chitasa commented 2 years ago

Remade old pr to comply with updates Added a new test for entity collisions

rom1504 commented 2 years ago

would appreciate reviews

rom1504 commented 2 years ago

@U5B maybe you'd like to take a look at this ?

U5B commented 2 years ago

Another feature to this is to implement collisionRule from scoreboard.

Chitasa commented 2 years ago

I had to extract the physics object out of the Physics class so there's a placeholder value until it can be set when mcdata is defined. Is there any better way to do this or is this fine?

Robbilie commented 2 years ago

happy to test this once rebased @O-of :) from what (little) i understand the code looks good to me too :P

rom1504 commented 2 years ago

please finish