PrismarineJS / prismarine-physics

Provide the physics engine for minecraft entities
MIT License
35 stars 39 forks source link

fix attribute key 'uuid' vs 'UUID' #74

Closed WhoTho closed 2 years ago

rob9315 commented 2 years ago

no, modifiers are a binary datastructure. their capitalization or naming in general does not matter.

rob9315 commented 2 years ago

if the code is checking the wrong capitalization, that is a bug and should be fixed. you can look up the actual names used in minecraft-data, specifically the protocol.json files. they determine the naming used.

rob9315 commented 2 years ago

uuid is supposed to be lowercase, changing it would be a breaking api change.

WhoTho commented 2 years ago

well im fine with it being lowercase, but it doesnt match up with the keys sent by the server and thus fails the modifer.uuid === uuid check.

rob9315 commented 2 years ago

there is no capitalized uuid field anywhere in the protocol except for this one which has nothing to do with modifiers

rob9315 commented 2 years ago

the capitalized uuid has to be set somewhere else

WhoTho commented 2 years ago

the capitalized uuid comes directly from the server (shown by the last picture which uses pakkit to show packets). either way the fix im proposing should cover both so it doesnt matter.

rob9315 commented 2 years ago

which version is this?

rob9315 commented 2 years ago

it seems the naming was changed at some point, 1.7 has UUID when 1.19 has uuid

rob9315 commented 2 years ago

1.7 and 1.8 have UUID when all other versions have uuid, i'll make a pr to adjust 1.7 and 1.8.

rob9315 commented 2 years ago

after that is merged, this issue should be fixed.

rom1504 commented 2 years ago

fixed in mcdata