PrismarineJS / prismarine-physics

Provide the physics engine for minecraft entities
MIT License
35 stars 39 forks source link

Add pitch to player state #98

Closed IceTank closed 1 year ago

rom1504 commented 1 year ago

how come it worked before / what will change after this PR ?

IceTank commented 1 year ago

how come it worked before / what will change after this PR ?

There was never anything that actually used pitch. Only yaw was used in physics calculations.

rom1504 commented 1 year ago

is something using pitch now ?

IceTank commented 1 year ago

is something using pitch now ?

No. But if anything ever want to implement something like flying with an elytra it might be used. I can also be used when you are trying to simulate the bot's movements without moving the bot. Pathfinder does simulation but does not use pitch as it always sets pitch to 0 for simplicity.

IceTank commented 1 year ago

@rom1504 is there anything that prevents this from being merged?

rom1504 commented 1 year ago

We can merge but is this only adding an unused line of code or is there any plan to use it ?

rom1504 commented 1 year ago

Please add to doc (in readme)