Updated writeLevel to use nbt.writeJsObject

PrismarineJS / prismarine-provider-anvil

Anvil Storage Provider implementation.

13 stars 26 forks source link

Updated writeLevel to use nbt.writeJsObject #41

Closed GroobleDierne closed 3 years ago

GroobleDierne commented 3 years ago

Waiting for https://github.com/PrismarineJS/prismarine-nbt/pull/44 to be merged

extremeheat commented 3 years ago

This seems like a breaking change to me. What’s the benefit aside from the shorter syntax?

GroobleDierne commented 3 years ago

Currently you can only define the RandomSeed but level.dat aims to contain way more information, the current approach is hardcoding values, with this pr you can add any informations you want without changing this function and without introducing breaking changes in the future.

rom1504 commented 3 years ago

we decided to go with the builder pattern in pnbt