PrismarineJS / prismarine-provider-anvil

Anvil Storage Provider implementation.
13 stars 26 forks source link

Write the chunk x and z position like vanilla does #51

Closed Paulomart closed 2 years ago

Paulomart commented 2 years ago

Vanilla writes the chunks x and z coordinates into the chunks level nbt. Some tools like mcmap 1 depend on this behavior and fail if the values are missing.

rom1504 commented 2 years ago

Feel free to do a release pr like https://github.com/PrismarineJS/prismarine-provider-anvil/pull/30/files (that auto release to npm on merge)

Paulomart commented 2 years ago

@rom1504 IMO that would be a major release per semver right?

rom1504 commented 2 years ago

no it's minor, it doesn't break anything, the function prototype you changed was not exposed

Paulomart commented 2 years ago

@rom1504 done: https://github.com/PrismarineJS/prismarine-provider-anvil/pull/52