PrismarineJS / prismarine-schematic

Read and write schematic of any minecraft version, provide them in a convenient and stable API
https://prismarine.js.org/prismarine-schematic/
MIT License
21 stars 8 forks source link

Add copy function and tests #22

Closed Karang closed 3 years ago

Karang commented 3 years ago

Also fix a bug in the paste function (the offset was not accounted for) and in the end getter (off by one error).

rom1504 commented 3 years ago

I think we should have benchmarks to check the speed of paste and copy

rom1504 commented 3 years ago

Btw, we could decide to use the sync API of pworld. (We discussed at some point that with the proper handling of null, and handling of loading by the caller, the async API could be completely removed, which would simplify things)