search

PrismarineJS / prismarine-viewer

Web based viewer for servers and bots
https://prismarinejs.github.io/prismarine-viewer/
MIT License
255 stars 71 forks source link

World rendering improvements #408

Closed zardoy closed 9 months ago

zardoy commented 1 year ago

Basically I picked almost all changes from my fork here. I've also dramatically changed the build pipeline (migrated everything to esbuild), but I didn't pick these changes here. So it won't be in sync. I've separated changes by commits so I do hope it is still not hard to review :)

Added missing texture from invsprite from prismarine web client. Though it would be cool to think of a way to bring old behavior for some blocks if user really wants it for some reason.

Resourcepack support is done by supplying a custom atlas image generated with script like this. Of course would be better to think of exposing such functionality here, but it is not my priority for now. Also added a way to supply custom block state json so you can have any texture size (e.g. 1024x)

Also in prismarine web client I'm currently going to load textures and block states before joining the server or implement a loader indicator so user have understanding that textures are being loaded.

rom1504 commented 9 months ago

hi, sorry for delay

CI is failing, could you make it work?

rom1504 commented 9 months ago

I fixed the ci

rom1504 commented 9 months ago

Most things LGTM

I left 2 comments

rom1504 commented 9 months ago

/makerelease

zardoy commented 9 months ago

Thanks!