PrismarineJS / prismarine-web-client

Minecraft web client running in your browser
https://prismarinejs.github.io/prismarine-web-client/
MIT License
444 stars 144 forks source link

Avoid copy of unchanged files #278

Closed Saiv46 closed 2 years ago

Saiv46 commented 2 years ago

It uses modified time of source and destination files (if exists) to filter out unchanged files from being copied on build.

Closes #210

Saiv46 commented 2 years ago
Module not found: Error: Can't resolve 'tls' in '/home/runner/work/prismarine-web-client/prismarine-web-client/node_modules/https-proxy-agent/dist'

The fuck? How my PRs breaking other webpack plugins in unexpected ways?

rom1504 commented 2 years ago

I fixed the tls issue

rom1504 commented 2 years ago

@KalmeMarq @AwesomestCode can you check if this works for you?

Things that should work:

rom1504 commented 2 years ago

this will get closed in 5 days if nobody tests it

Saiv46 commented 2 years ago

Tested with latest webpack

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
    - add a fallback 'resolve.fallback: { "url": require.resolve("url/") }'
    - install 'url'
If you don't want to include a polyfill, you can use an empty module like this:
    resolve.fallback: { "url": false }
 @ ./node_modules/.pnpm/github.com+PrismarineJS+net-browserify@0acebf76d5a_5678e2fd34bc6a9aacd7b63820e4e40f/node_modules/net-browserify/browser.js 4:11-26
 @ ./index.js 11:12-26
Saiv46 commented 2 years ago

I still can't get build work with PNPM, while NPM installing packages slower on my new SSD

AwesomestCode commented 2 years ago

Quickly checked npm start on GitPod. It compiles successfully though some assets seem to be missing? Or my computer might just be weird.

Screenshot 2022-03-08 at 15 56 33

Edit: also tested on my Chromebook. Same issue, happens with npm run build-start too.

Confirmed that the issue does not happen on master.

Saiv46 commented 2 years ago

Closed in favor of #253