Implement auth - Githubissues

PrismarineJS / prismarine-web-client

Minecraft web client running in your browser

https://prismarinejs.github.io/prismarine-web-client/

MIT License

435 stars 122 forks source link

Implement auth #322

Closed sverben closed 1 year ago

sverben commented 1 year ago

This enables online mode using a chrome extension Extension

Possible enhancements:

Add a button on the play_screen component to display where to download the extension
Upload to Chrome Web Store

sverben commented 1 year ago

This closes #251 and #27

rom1504 commented 1 year ago

interesting solution. Could someone try it ? maybe @AwesomestCode ?

IlanLuci commented 1 year ago

Doesn't seem to be working on 1.8.9 and potentially other versions as well. When I try to join minemen.club or hypixel i get "RangeError: Invalid WebSocket frame: RSV1 must be clear" referencing events.js:377 throw er; // Unhandled 'error' event -- not sure if this is something on my end or a problem for others as well. I'm on a mac testing on brave browser. I am going to install chrome rn and see if its a problem there too.

Verdanix commented 1 year ago

When will this get approved? If it even will...

rom1504 commented 1 year ago

seems it doesn't work so let's not merge