search

PrismarineJS / prismarine-web-client

Minecraft web client running in your browser
https://prismarinejs.github.io/prismarine-web-client/
MIT License
444 stars 144 forks source link

Should show error screen on error #350

Closed zardoy closed 1 year ago

zardoy commented 1 year ago

With this, it should show the error screen when an error actually happens (right now setTimeout seems to be removing it).

Though in my fork I've rewritten the error screen so it's now possible to go back without having to reload the page. But I've also rewritten the screen history management, so I don't think I'll ever have time to cherry-pick so many commits, so I'm providing a simpler copy-paste solution for now.

zardoy commented 1 year ago

Let me know what changes you will be interested in. I have changed the directory structure but I think I can still try to copy-paste some improvements & important bug fixes (such as incorrect creative bars update) ... or copy all changes along with reverting some of the commits

rom1504 commented 1 year ago

please fix the ci

zardoy commented 1 year ago

I don't think changes in this PR caused ci failure. I had the same problem with Webpack (and Vite) locally. Seems they work badly when it comes to bundling large files (like these json files). CopyPlugin also may cause it I believe. I have solved these problems in one of the first commits, so have to remember.

Anyway, I'll try to adjust the build process in this PR then. if you are interested in some other changes please let me know, I will try to rebase and group changes you interested in.

Update: FYI not sure why (it doesn't happen on ci & in docker) but when I try to run npm i locally I get ERESOLVE in rollup dep if I don't up deps manually.

rom1504 commented 1 year ago

indeed CI is broken in main https://github.com/PrismarineJS/prismarine-web-client/actions/runs/5984401321/job/16235532976?pr=352

it needs to be fixed before we can merge anything

zardoy commented 1 year ago

I have solved these problems in one of the first commits, so have to remembe

Sorry, I lied, actually I just removed bedrock files from the build completely (because they have too large blocksj2b files). However, bedrock is supported here, right? Do you know how blocksj2b are used here or we can remove them? I'm not even sure how these files are used in prismarine projects at all yet.