PrismarineJS / prismarinejs.github.io

https://prismarinejs.github.io
MIT License
11 stars 3 forks source link

Feat(next.js): Migration to next.js #68

Closed AugustinMauroy closed 1 year ago

AugustinMauroy commented 1 year ago

Introduce Next.js

Sadly, it's not really the same in style. but in content it's same.

After merge of this pr I will improve the project.

don't worry!

Implement next.js help to maintain the website

feature added

feature can be add in futur

It's not for this pr it's for after merging

Related Issue

67

socket-security[bot] commented 1 year ago

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📞 Telemetry

This package contains telemetry which tracks you.

Package Note Source
next@13.2.1 (added) Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 package-lock.json, package.json
Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ⚠️ 1 issue
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore next@13.2.1

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

rom1504 commented 1 year ago

CI failing

AugustinMauroy commented 1 year ago

CI failing

MMM it's about telemetry data. What do you thinks? nextjs info

AugustinMauroy commented 1 year ago

To merge I propose to use squash and merge

AugustinMauroy commented 1 year ago

Review is ready !

@rom1504

rom1504 commented 1 year ago

CI failing

rom1504 commented 1 year ago

This doesn't seem to bring any new features What's the plan on this ?

AugustinMauroy commented 1 year ago

CI failing

IDK why? Because I have add .env with telemetry at off and add socket file to with ignore the package. So idk.

AugustinMauroy commented 1 year ago

This doesn't seem to bring any new features What's the plan on this ?

Technically it's just the migration.

AugustinMauroy commented 1 year ago

They are feat added:

AugustinMauroy commented 1 year ago

@rom1504

Can you do the last review ?

And do this @SocketSecurity ignore next@13.1.6

rom1504 commented 1 year ago

blocked on adding any new feature (can be done in other PRs)

rom1504 commented 1 year ago

this increases the complexity

I think we should rather decrease it

AugustinMauroy commented 1 year ago

It increases the complexity a bit. But it also increases the DX and stability.

AugustinMauroy commented 1 year ago

Oups fail for closing

rom1504 commented 1 year ago

apparently it was not clear in my previous messages: if there is no feature added, I think we should not move to next.js

ghost commented 1 year ago

why was this closed

AugustinMauroy commented 1 year ago

https://github.com/PrismarineJS/prismarine-contribute/issues/9