PrismaticFlower / shaderpatch

Improved shaders (and fun stuff for modders) for Star Wars Battlefront II (2005) - Incompatible with Classic Collection
MIT License
39 stars 2 forks source link

Custom materials in unit selection screen do not get lit properly #108

Open DoctorAnsem opened 4 years ago

DoctorAnsem commented 4 years ago

I should've mentioned this much earlier, probably, but up until now I sort of just brushed it off as a minor cosmetic bug. But alas, the materials in spawn screen are marginally darker than when spawned in the world, and it made unlocked units look so dark my brain associated it as the unit still locked behind points. So minor cosmetic issue, but it has an ever so slight impact on gameplay.

PrismaticFlower commented 4 years ago

I suspect this is likely a result of units on the spawn screen getting drawn after postprocessing is applied. That'll be causing the linear colours output by the material shaders to not end up having sRGB compression applied to them, causing them too look overly dark when displayed.

As the code base currently stands there is no easy way to fix this without also possibly increasing the cost of all models using custom materials being drawn. But it is annoying and something I will be thinking about how to fix effectively for a future release.