search

PrismaticFlower / shaderpatch

Improved shaders (and fun stuff for modders) for Star Wars Battlefront II (2005) - Incompatible with Classic Collection
MIT License
38 stars 2 forks source link

Stock bump shader can have adverse effects on lighting #115

Closed auri0n closed 4 years ago

auri0n commented 4 years ago

I've known about this for a while, but never had good before/after shots until now. Here are two screenshots: one of the Mos Eisley barge area as it appears in the shipped tat2.lvl (which uses bumpmaps) and the other of the same area, but from the ModTools version of the map (which doesn't use bumpmaps) tat2_bad tat2_good It almost looks like there's some kind of 'brightness rescaling' being performed by the bump shader, but maybe that's totally wrong.

PrismaticFlower commented 4 years ago

I'm actually unsure what could be causing this. As far as I can tell the shader responsible does handle lighting in a more or less identical fashion. Though I did do some investigations and that led me to fixing another issue with HDR Rendering.

I do see what you're talking about but I'm unsure for now if there's a possible fix for it. I will leave this issue open for now however, just in case. There are still some things I can try looking into if I find the time.

auri0n commented 4 years ago

No problem ;) thanks for looking into this. What's even more bizarre is that the issue isn't present for everyone; it must have something to do with GPUs/motherboards/chipsets or something like that. If I set my lighting quality to high (with shaderpatch disabled), I get a crash to desktop on Mos Eisley, Naboo and maybe a couple other maps. I've looked through the Steam support forum and it looks like only one or two other people have this problem. Who knows what the cause really is lol, I could never blame you for not being able to pinpoint something like this.