search

PrismaticFlower / shaderpatch

Improved shaders (and fun stuff for modders) for Star Wars Battlefront II (2005) - Incompatible with Classic Collection
MIT License
38 stars 2 forks source link

Certain lights flicker/render incorrectly #26

Closed auri0n closed 5 years ago

auri0n commented 6 years ago

This problem occurs when effects are enabled and disabled, but is much more noticeable when HDR rendering is turned on. I don't believe this was present until the 0.8.x releases. Here are a few short clips highlighting the issue:

Two with HDR disabled (https://i.imgur.com/y5qYlHC.mp4) (https://i.imgur.com/OycHcKf.mp4)

and another with it enabled (https://i.imgur.com/w3b5hgR.mp4).

Lens flares have a similar problem; they tend to flicker instead of fading out smoothly when covered by something (https://i.imgur.com/YGx4pRc.mp4).

Sometimes they fade out correctly, though (https://i.imgur.com/OEDUGYd.mp4).

PrismaticFlower commented 6 years ago

Thanks for the detailed report. I suspect this is being caused by a hack that let's SP use R10G10B10A2 formats to significantly reduce colour banding (when Effects are active) in some situations.

I feel this is a worthwhile tradeoff but it'd be better if it wasn't needed at all. I think it should be possible to fix it as the render targets used with the sample shader probably don't need to be the same as the ones being used for the rest of drawing, which should mean it's possible to just have it use R8G8B8A8 targets which would remove the need for the hack. Or it might be possible to just use a different channel than the alpha one in flare and sample shaders, which would also remove the need for the hack.

In either event it would solve the problem without further compromise. Hopefully I'll have it fixed in the next version.

PrismaticFlower commented 5 years ago

v1.0.0 should've resolve this.