PrismaticFlower / shaderpatch

Improved shaders (and fun stuff for modders) for Star Wars Battlefront II (2005) - Incompatible with Classic Collection
MIT License
39 stars 2 forks source link

normal_ext.specular has funky shadow interaction #39

Closed DoctorAnsem closed 5 years ago

DoctorAnsem commented 5 years ago

This seems like such a blatantly obvious phenomenon so it's probably been mentioned already, but regardless. It turns out if the specular spot is being cast onto a shadowed surface, the color gets massively subtracted so it casts darkness instead.

specularblack

EDIT: You know something? It's not just the specular extension that has weird stuff happen with shadows. It seems on a normal_ext material without the specular extension, all shadows that are cast on the surface become pitch black. I definitely remember reading about this one before so maybe I didn't need to report this after all, but what's done is done.

PrismaticFlower commented 5 years ago

I did think I had fixed this but it must have only been in some circumstances. Thanks for letting me know, I'll have to look into it.

I definitely remember reading about this one before so maybe I didn't need to report this after all, but what's done is done.

If there isn't an issue open for it then always feel free to assume I either don't know about it or I have forgotten about it.

PrismaticFlower commented 5 years ago

v1.0.0 should've resolve this. Let me know if it hasn't