search

Prismwork / EMITrades

Villager trading for EMI.
https://discord.gg/zfPcG37uvm
MIT License
9 stars 5 forks source link

[Bug]: Villagers names on trading tab not translated #24

Open ffuentesm opened 6 months ago

ffuentesm commented 6 months ago

What happened? Would be nice to fix this long string name for their proper name. 297250034-a425d9d2-a5f9-4723-962b-ad9a10b7d908

Minecraft Version: 1.20.1 Ice and Fire version: iceandfire 2.1.13-1.20.1+build.beta-2 EMI trade: forge-1.2.1

Flamarine commented 6 months ago

does ice & fire itself provide translation of this profession? if not then it's an issue of ice & fire's side.

ffuentesm commented 6 months ago

I asked them about this problem first, as I assume is their problem since other moded villagers have no problem in their names, but they said: https://github.com/AlexModGuy/Ice_and_Fire/issues/5091#issuecomment-1951314865 image

So I posted here just in case.

Flamarine commented 6 months ago

hmm, seems like this profession's translation key does not follow what is expected by emi trades. honestly i don't know how i can fix this on my side, as other villagers do follow the expected translation key format (which does not expect the modid but only the name), meaning i'll have to make a hardcode fix for this (which is bad and meaningless and thus something i don't really want to do) i'll left this open tho to see what i may do in the future.

ffuentesm commented 6 months ago

hum... I think they are just using an outdated translation key, as they just updated from 1.16.5 to 1.20.1. And maybe JEP just hardcodes the translation.

Flamarine commented 6 months ago

i see. might look into this later. but i cannot touch my device in the next few days so you may need to wait for a while

ffuentesm commented 6 months ago

Hum, I had a similar problem in IE villagers, and it seems the translation key has a discrepancy of : instead of entity.minecraft.villagers.mod_id.name it uses entity.minecraft.villagers.mod_id:name as well as entity.minecraft.villagers.name image